RKWard is in kdereview

[Thomas Friedrichsmeier]

Hi!

KDE.org has been our home for a almost four years, now (after over a
decade on sourceforge), but somehow I've kept procrastinating on the
final step: Today I'd like to ask you to start reviewing RKWard for
inclusion into exragear (coming from playground).


RKWard is an easy to use and easily extensible IDE/GUI for R (a
powerful language and environment for statistical computing, if you
did not know it, yet). It aims to combine the power of the
R-language with the ease of use of commercial statistics tools.

RKWard is used productively on Linux/BSD, Mac, and Windows.

We have quite a heavy code-base, and some of it dates back to the time
when KDE 3.0 was still fresh. I guess reviewing this will not be an
easy task, and honestly I have no idea where I would recommend you to
start. So please just ask whatever you need to know, and I'll try my
best to help you around.

Looking forward to your feedback!

Thomas Friedrichsmeier
for the RKWard team

[Albert Astals Cid]

Post by Thomas Friedrichsmeier
Hi!
KDE.org has been our home for a almost four years, now (after over a
decade on sourceforge), but somehow I've kept procrastinating on the
final step: Today I'd like to ask you to start reviewing RKWard for
inclusion into exragear (coming from playground).

the i18n folder seems like from the past and something you should not need if in kde infrastructure. Could you delete it?

Also I'd suggest you compile enabling -DECM_ENABLE_SANITIZERS="address;undefined"

There's a few memory leaks (reported at exit) that you may want to have a look.

And there's also a few undefined behaviour warnings on exit, you've them marked as "known" things but it'd be good if you could find a way to fix them.

Your help menu is for some reason missing the Change Language option, i tried to do it a quick fix but could not, i would appreciate if you could find a way to only define the extra actions and not all of them (like we do for example in okular).

I've no idea about R so can't comment on the app itself ^_^

Cheers,
Albert

Post by Thomas Friedrichsmeier
RKWard is an easy to use and easily extensible IDE/GUI for R (a
powerful language and environment for statistical computing, if you
did not know it, yet). It aims to combine the power of the
R-language with the ease of use of commercial statistics tools.
RKWard is used productively on Linux/BSD, Mac, and Windows.
We have quite a heavy code-base, and some of it dates back to the time
when KDE 3.0 was still fresh. I guess reviewing this will not be an
easy task, and honestly I have no idea where I would recommend you to
start. So please just ask whatever you need to know, and I'll try my
best to help you around.
Looking forward to your feedback!
Thomas Friedrichsmeier
for the RKWard team

[Luca Beltrame]

Il giorno Sat, 6 Oct 2018 15:45:39 +0200

Post by Thomas Friedrichsmeier
final step: Today I'd like to ask you to start reviewing RKWard for
inclusion into exragear (coming from playground).

As a longtime user of rkward (since the KDE 3 times) and as someone who
still uses it for his day to day job I can't comment much on the code
itself but I just want to say: congratulations for reaching this
milestone!

[Jonathan Riddell]

Very nice

It installs two desktop files which creates duplicate menu entries
/usr/share/applications/org.kde.rkward-open.desktop
/usr/share/applications/org.kde.rkward.desktop

The .desktop files call it a "GUI for R" which is not a great
description, everything in the menu is a GUI. I recommend "R
Statistical Programming" or "IDE for R" maybe.

I tidied up the files with the icon licence as they could easily be lost.

It depends on WebKit which is not supported, could this be ported to WebEngine?

It's uncommon having debian/ packaging directly in the source and
there's also debian-official/ which could get confusing and
out-of-sync and messy. I recommend moving them to another archive.
Storing the packaging in KDE neon Git would be cool as we already have
packaging for all the rest of KDE software. Using salsa.debian
pkg-kde team would also make sense but would need different
permissions. Either way we should get this into Neon, give me a ping
to sort that out.

Jonathan





On Sat, 6 Oct 2018 at 14:47, Thomas Friedrichsmeier

Post by Thomas Friedrichsmeier
Hi!
KDE.org has been our home for a almost four years, now (after over a
decade on sourceforge), but somehow I've kept procrastinating on the
final step: Today I'd like to ask you to start reviewing RKWard for
inclusion into exragear (coming from playground).
RKWard is an easy to use and easily extensible IDE/GUI for R (a
powerful language and environment for statistical computing, if you
did not know it, yet). It aims to combine the power of the
R-language with the ease of use of commercial statistics tools.
RKWard is used productively on Linux/BSD, Mac, and Windows.
We have quite a heavy code-base, and some of it dates back to the time
when KDE 3.0 was still fresh. I guess reviewing this will not be an
easy task, and honestly I have no idea where I would recommend you to
start. So please just ask whatever you need to know, and I'll try my
best to help you around.
Looking forward to your feedback!
Thomas Friedrichsmeier
for the RKWard team

[Thomas Friedrichsmeier]

Hi!

Thanks for your first feedback items. I'll try to respond to
everything, eventually, but I'm probably not going to be too fast.
(Albert: I'll get back to your items!)

On Wed, 10 Oct 2018 11:21:05 +0100

Post by Jonathan Riddell
It installs two desktop files which creates duplicate menu entries
/usr/share/applications/org.kde.rkward-open.desktop
/usr/share/applications/org.kde.rkward.desktop

The difference here is that one reuses a running session, while the
other does not. The first is great for opening several R scripts from a
file manager, while the latter is geared at being run from the menu.

For me, this produces only a single menu entry, too, but quite likely
this is simply not the right way to do this. Any pointers?

Post by Jonathan Riddell
The .desktop files call it a "GUI for R" which is not a great
description, everything in the menu is a GUI. I recommend "R
Statistical Programming" or "IDE for R" maybe.

The idea to convey is that is not targetted at programmers,
exclusively, but at people who want to get something done with R.
That's why I shy away from "IDE" and "Programming" a bit. How dows
"Graphical frontend to R" sound to you?

Post by Jonathan Riddell
I tidied up the files with the icon licence as they could easily be lost.

Thanks!

Post by Jonathan Riddell
It depends on WebKit which is not supported, could this be ported to WebEngine?

We're in a somewhat uncomfortable situation, here, as we're currently
stuck with the MinGW-API on Windows, which means no QtWebEngine for us
(see also https://marc.info/?l=kde-core-devel&m=145716183226732&w=2). I
do have several ideas to work around this, the simplest being to use
#ifdefs to use QtWebEngine on non-Windows platforms. I had started along
that track, but quickly abandoned my efforts after finding out that
Debian did not have QtWebEngine, either, then.

I guess I'll have to pick this up again.

Post by Jonathan Riddell
It's uncommon having debian/ packaging directly in the source and
there's also debian-official/ which could get confusing and
out-of-sync and messy. I recommend moving them to another archive.

We also have a macports-packaging (and I just noted we still had old
Windows packaging files from before KF5; now removed). Note that these
are not included in the source releases.

Post by Jonathan Riddell
Storing the packaging in KDE neon Git would be cool as we already have
packaging for all the rest of KDE software. Using salsa.debian
pkg-kde team would also make sense but would need different
permissions. Either way we should get this into Neon, give me a ping
to sort that out.

I can move them to a different archive (but isn't that just as
out-of-sync, only more obviously, so?). But in fact I totally would not
mind "outsourcing" the entire debian packaging for RKWard. That's not
an area that I feel terribly competent, in.

So for all of these matters, any direction you would recommend, really.
Ping!

Regards
Thomas

[Thomas Friedrichsmeier]

On Wed, 10 Oct 2018 18:24:38 +0200

how would it affect our various PPAs if there was no debian/
directory in the sources?

In fact, we'd have to keep the debian packaging somewhere, and "merge"
it into the sources while building (we do the same for translations in
the PPAs, so the procedure itself is pretty clear). But we only need the
"sloppy" variant of the packaging for this purpose (i.e. the one that
just works, without trying to keep up the latest debhelper
compatibility levels, and such; "debian" instead of "debian-official").

Regards
Thomas

[Jonathan Riddell]

I added it into Neon
https://packaging.neon.kde.org/neon-packaging/rkward.git/
https://build.neon.kde.org/view/1%20release%20⛰/job/bionic_release_neon-packaging_rkward/

It's the norm for Debian packages to have their packaging kept
separate from the upstream source including for PPAs, keeping them
together is quite confusing.

QGuiApplication should include ability for single instance application
rather than having separate .desktop files for it.

Jonathan


On Wed, 10 Oct 2018 at 17:33, Thomas Friedrichsmeier

Post by Thomas Friedrichsmeier
On Wed, 10 Oct 2018 18:24:38 +0200

how would it affect our various PPAs if there was no debian/
directory in the sources?

In fact, we'd have to keep the debian packaging somewhere, and "merge"
it into the sources while building (we do the same for translations in
the PPAs, so the procedure itself is pretty clear). But we only need the
"sloppy" variant of the packaging for this purpose (i.e. the one that
just works, without trying to keep up the latest debhelper
compatibility levels, and such; "debian" instead of "debian-official").
Regards
Thomas

[Thomas Friedrichsmeier]

Hi,

On Fri, 12 Oct 2018 18:04:45 +0100

Post by Jonathan Riddell
I added it into Neon
https://packaging.neon.kde.org/neon-packaging/rkward.git/
https://build.neon.kde.org/view/1%20release%20⛰/job/bionic_release_neon-packaging_rkward/

thanks!

Post by Jonathan Riddell
It's the norm for Debian packages to have their packaging kept
separate from the upstream source including for PPAs, keeping them
together is quite confusing.

Ok, will do. It may take me a while, though, as I'll have to be careful
not to break our automated builds on our Ubuntu PPAs (as pointed out by
Meik). But ideally, I'd also like to combine this step with handing
over our official debian packaging (i.e. the "debian-official" folder)
to the debian qt/kde-team.

Is there any hope for that, or what can I do to make that happen?

Post by Jonathan Riddell
QGuiApplication should include ability for single instance application
rather than having separate .desktop files for it.

Not quite what we want. Having several instances is quite ok (one for
each of several "projects"), _except_ that's very unlikely to be the
thing a user wants when selecting to open several .R-files (all files
should go into the same "project"). So what we are looking for is:

1. When invoking RKWard from the Application Menu, always start a new
instance.
2. When invoking RKWard from Open With..., always open the file in an
existing RKWard instance (if any).

We already have a command line parameter "--reuse" to select the
desired behavior. But how to fit both into a single .desktop file?

Regards
Thomas

Post by Jonathan Riddell
On Wed, 10 Oct 2018 at 17:33, Thomas Friedrichsmeier

Post by Thomas Friedrichsmeier
On Wed, 10 Oct 2018 18:24:38 +0200

how would it affect our various PPAs if there was no debian/
directory in the sources?

In fact, we'd have to keep the debian packaging somewhere, and
"merge" it into the sources while building (we do the same for
translations in the PPAs, so the procedure itself is pretty clear).
But we only need the "sloppy" variant of the packaging for this
purpose (i.e. the one that just works, without trying to keep up
the latest debhelper compatibility levels, and such; "debian"
instead of "debian-official").
Regards
Thomas

[Thomas Baumgart]

Hi,

On Freitag, 12. Oktober 2018 22:03:16 CEST Thomas Friedrichsmeier wrote:

[...]

Post by Thomas Friedrichsmeier

Post by Jonathan Riddell
QGuiApplication should include ability for single instance application
rather than having separate .desktop files for it.

Not quite what we want. Having several instances is quite ok (one for
each of several "projects"), _except_ that's very unlikely to be the
thing a user wants when selecting to open several .R-files (all files
1. When invoking RKWard from the Application Menu, always start a new
instance.
2. When invoking RKWard from Open With..., always open the file in an
existing RKWard instance (if any).
We already have a command line parameter "--reuse" to select the
desired behavior. But how to fit both into a single .desktop file?

That's exactly how kate behaves. Using krunner to start it always creates a new instance. Using the 'Open with' option in dolphin opens the file in an existing instance. Or am I missing something? Maybe, you take a look at kate's .desktop file.

[Thomas Friedrichsmeier]

Hi,

On Sat, 13 Oct 2018 06:59:53 +0200

Post by Thomas Baumgart
That's exactly how kate behaves. Using krunner to start it always
creates a new instance. Using the 'Open with' option in dolphin opens
the file in an existing instance. Or am I missing something? Maybe,
you take a look at kate's .desktop file.

thanks for the pointer (and also thanks, Meik for the analysis).

I added an --autoreuse option which will reuse the running session, if
any urls are specified on the command line, similar to kate's "-b"
option. This allowed to remove the second .desktop file.

I've kept the --reuse option around. Probably it won't be needed a lot,
but it's cheap to keep, and allows to remain flexible and backwards
compatible.

Regards
Thomas

[meik michalke]

hi,

Post by Thomas Friedrichsmeier
1. When invoking RKWard from the Application Menu, always start a new
instance.
2. When invoking RKWard from Open With..., always open the file in an
existing RKWard instance (if any).
We already have a command line parameter "--reuse" to select the
desired behavior. But how to fit both into a single .desktop file?

the .desktop files of kate an RKWard are actually not that different.

the important difference seems to be the very behaviour of the tools
themselves: kate is always launched using "kate -b %U", and if "%U" happens to
be empty, it launches a new instance, if not it tries to open it in a running
instance.

currently, RKWard is being launched "rkward -qwindowtitle %c" to get new
instances, and "rkward --reuse %F" to open files in existing ones, by the two
.desktop files, respectively.

now, RKWard reuses a running instance regardless of "%F" if launched with "--
reuse". so in order to have it all in one desktop file, we'd have to change
RKWard's behaviour: if launched given a file, try to reuse a running session,
if not start a new one. this would probably render the "--reuse" parameter
obsolete.


viele grüße :: m.eik

[Jonathan Riddell]

Post by Thomas Friedrichsmeier
Ok, will do. It may take me a while, though, as I'll have to be careful
not to break our automated builds on our Ubuntu PPAs (as pointed out by
Meik). But ideally, I'd also like to combine this step with handing
over our official debian packaging (i.e. the "debian-official" folder)
to the debian qt/kde-team.
Is there any hope for that, or what can I do to make that happen?

Talk to some folks on the team, maybe start with Scarlett (CCed) who is getting some good stuff into there.

Jonathan

[Scarlett Clark]

Yes, I have already begun the process of taking this over in debian
official.
Cheers,
Scarlett

Post by Jonathan Riddell

Post by Thomas Friedrichsmeier
Ok, will do. It may take me a while, though, as I'll have to be careful
not to break our automated builds on our Ubuntu PPAs (as pointed out by
Meik). But ideally, I'd also like to combine this step with handing
over our official debian packaging (i.e. the "debian-official" folder)
to the debian qt/kde-team.
Is there any hope for that, or what can I do to make that happen?

Talk to some folks on the team, maybe start with Scarlett (CCed) who is
getting some good stuff into there.
Jonathan

[Jonathan Riddell]

There's no appstream metainfo file nor product-screenshot
https://community.kde.org/Guidelines_and_HOWTOs/AppStream

Jonathan

On Sat, 6 Oct 2018 at 14:47, Thomas Friedrichsmeier

Post by Thomas Friedrichsmeier
Hi!
KDE.org has been our home for a almost four years, now (after over a
decade on sourceforge), but somehow I've kept procrastinating on the
final step: Today I'd like to ask you to start reviewing RKWard for
inclusion into exragear (coming from playground).
RKWard is an easy to use and easily extensible IDE/GUI for R (a
powerful language and environment for statistical computing, if you
did not know it, yet). It aims to combine the power of the
R-language with the ease of use of commercial statistics tools.
RKWard is used productively on Linux/BSD, Mac, and Windows.
We have quite a heavy code-base, and some of it dates back to the time
when KDE 3.0 was still fresh. I guess reviewing this will not be an
easy task, and honestly I have no idea where I would recommend you to
start. So please just ask whatever you need to know, and I'll try my
best to help you around.
Looking forward to your feedback!
Thomas Friedrichsmeier
for the RKWard team